Open
Conversation
Owner
|
Hey. Still premature because it makes more sense to test it when the implementation is a bit more complete. Many things will change since this program is designed to show programming, is not a "real" project. I'll keep this open as a reminder that we should add some testing, and maybe in Python indeed :) |
Author
|
Hi! Thanks for your feedback and for the interesting project! (you gave me the idea to try a mini porting to python) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a prototype test case using "nc"
(Obviously it would have also made sense to build a client in Python, but I wanted to limit the test to the behavior described in the video, without adding features)
During the implementation of the test case, which obviously runs faster than a user test, the need arose to insert a "sleep" command... which is a smell and should turn on some light bulbs